Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upstream URI. #2504

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Update upstream URI. #2504

merged 1 commit into from
Oct 6, 2016

Conversation

daspecster
Copy link
Contributor

@daspecster daspecster commented Oct 6, 2016 •
edited
Loading

  • Fixes upstream URL in CONTRIBUTING.rst.

@dhermes, this is the real issue anyway. If you think any of the other stuff from #2501 was worth while, let me know and I can add it.

Redux from #2501

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2016
@daspecster
Copy link
Contributor Author

daspecster commented Oct 6, 2016 •
edited
Loading

image

See: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/165483428#L201

@daspecster
Copy link
Contributor Author

daspecster commented Oct 6, 2016 •
edited
Loading

screen shot 2016-10-06 at 6 50 49 am

@dhermes, if the "bump" commit is removed then travis: tox -e lint goes haywire. I'm guessing it's something to do with the caches on travis.

My thought is to just clear the caches on travis anyway since there have been some huge changes and it might be good to have a fresh start. LMKWYT.

@daspecster daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 6, 2016
@daspecster daspecster mentioned this pull request Oct 6, 2016
Merged
@dhermes
Copy link
Contributor

dhermes commented Oct 6, 2016

@daspecster The problem is that there were no Python files to lint, so when building the command:

pycodestyle_command = ['pycodestyle'] + python_files

It just runs a bare

$ pycodestyle

I'll dump a fix in #2503.

@daspecster
Copy link
Contributor Author

Ah thank you! I wish I would have pieced that together this morning :/

@dhermes
Copy link
Contributor

dhermes commented Oct 6, 2016

@daspecster Remove the bogus 2nd commit and just merge away? Clearly editing CONTRIBUTING.rst will have no impact on any of our code.

@daspecster daspecster merged commit fdf6017 into googleapis:master Oct 6, 2016
@daspecster daspecster deleted the contributing-updates branch October 6, 2016 15:52
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Merge pull request googleapis#2504 from daspecster/contributing-updates
06a1a99 
Update upstream URI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daspecster @dhermes @googlebot